-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v9.0.0-beta.34 • Feedback wanted #642
Comments
noticed a useTransition regression, my modal close animation stopped working after upgrading (it's now opening with animation and closing instantly on v9) |
@brunolemos Your code looks fine at first glance. Can you reproduce in react-spring-examples, maybe? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
A beta feedback playground is a super nice idea @aleclarson let's make this a perfect release for everyone 😍👍You think i should tweet this out for exposure? |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
9.0.0-beta.2 is now available! 🎉 Please give it a test drive. 👍
edit: There seem to be some TypeScript issues, so I'll be publishing another beta in a bit. |
9.0.0-beta.3 is now available 👀😲 |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
@aleclarson Is this scheduled to be fixed in 9.x? |
@phaistonian Getting a 404 on your link |
@aleclarson works for me (kind of.) Trying to fork it fails, so I can't see if the issue exists in Error it shows is |
Sounds like #867, which is fixed in the latest canary. |
Looks like this is fixed using the new canary & new |
setting ref for RenderProps api breaks for import { Spring } from 'react-spring'
// ...
const ref = React.useRef(null)
// ...
return (
<Spring ref={ref}
{...}>
{...}
</Spring>
)
is setting ref for renderProps api deprecated? |
@jjang16 Please try with the latest canary. 👍 |
Running into an issue in combination with #601, if you're using typescript and you add For what it's worth, I'm in agreement with the OP of #601 that exporting es modules by default is confusing for people to work around, and goes against what the majority of modules do. |
I agree with you. @wbobeirne Actually, I am having the same problem, and building by artificially adding cjs.d.ts file to solve it. (with nextjs v9 & react-spring v9) This was too confusing. So, basically, it is necessary to provide a cjs.d.ts file and describe the guide on the document or use the basic module as cjs. What do you think? @aleclarson |
It appears there might be a regression of #910. Using Gatsby, I upgraded to 9.0.0-beta.34 and getting the error, No issues when running |
@wbobeirne @gtolarc The @NerdCowboy That hasn't been released under |
When might another canary land? We're excited for React-Spring, but a few broken things have had us unable to use it. Sadly other things broken in v8 prevent us from using it either. Hope I don't sound ungrateful asking. React-Spring is just awesome and I'm excited and looking forward to implementing it. |
Scratch that. Looks like useSpring now has a dependency array to keep it from updating when not necessary: const [{ x, y }, set] = useSpring(() => ({ x: 0, y: 0 }), []) |
@IngoValente Please open a new issue whose title starts with @slapbox Have all the issues you encountered been reported? Canary coming in the next few days maybe. |
@aleclarson thanks for your response, count me among the excited! #922 is a showstopper for us. It's the only major bug I'm aware of. |
@IngoValente If your props function was being called on every render, that was fixed with 55c5691 in the @slapbox I think there's a fix for that waiting to be released. Stay tuned! |
Hi, See the rocket example in "React Use Gesture": |
# line 21
- { initial: () => pos.get() }
+ { initial: () => pos.getValue() } |
…turns a boolean Fixes #642 (comment)
I found a bug using v9.0.0-beta.34 with the When I try to update any item of the array being passed as the first argument to I used the List-Reordering example from the docs as a base for simulating the bug: https://codesandbox.io/s/usetransitionflip-1w1ul?file=/src/index.js Try clicking on the "increase quantity" button on each item, you will see that the |
@iagodahlem try a canary release. I think your issue has been solved: #949 |
@iagodahlem @brotzky the latest canary available on npm is from January, but the PR is from March so it will be in the next canary. |
Replaced by #985 To those who reported an unsolved issue: Please reproduce it using |
Replaced by #985
The text was updated successfully, but these errors were encountered: