Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v9.0.0-beta.34 • Feedback wanted #642

Closed
aleclarson opened this issue Apr 21, 2019 · 238 comments
Closed

v9.0.0-beta.34 • Feedback wanted #642

aleclarson opened this issue Apr 21, 2019 · 238 comments

Comments

@aleclarson
Copy link
Contributor

aleclarson commented Apr 21, 2019

Replaced by #985

@brunolemos
Copy link
Contributor

brunolemos commented Apr 23, 2019

noticed a useTransition regression, my modal close animation stopped working after upgrading (it's now opening with animation and closing instantly on v9)

https://github.com/devhubapp/devhub/blob/6aa24bb96658ce2541f69f9eccfc3d65826c726b/packages/components/src/components/modals/ModalRenderer.tsx#L130-L172

@aleclarson
Copy link
Contributor Author

aleclarson commented Apr 23, 2019

@brunolemos Your code looks fine at first glance.

Can you reproduce in react-spring-examples, maybe?

@dbismut

This comment has been minimized.

@aleclarson

This comment has been minimized.

@dbismut

This comment has been minimized.

@drcmda
Copy link
Member

drcmda commented Apr 23, 2019

A beta feedback playground is a super nice idea @aleclarson let's make this a perfect release for everyone 😍👍You think i should tweet this out for exposure?

@dbismut

This comment has been minimized.

@flsilva

This comment has been minimized.

@pbock

This comment has been minimized.

@aleclarson aleclarson changed the title v9.0.0-beta.1 • Feedback wanted v9.0.0-beta.2 • Feedback wanted Apr 26, 2019
@aleclarson
Copy link
Contributor Author

aleclarson commented Apr 26, 2019

9.0.0-beta.2 is now available! 🎉 Please give it a test drive. 👍

  • lots of TypeScript fixes
  • all entry points now have a .d.ts module
  • minor fixes to useSpring 92c0e48
  • minor fixes to useTrail 7c557bd
  • added support for config.decay to be a number

edit: There seem to be some TypeScript issues, so I'll be publishing another beta in a bit.

@aleclarson aleclarson changed the title v9.0.0-beta.2 • Feedback wanted v9.0.0-beta.3 • Feedback wanted Apr 26, 2019
@aleclarson
Copy link
Contributor Author

9.0.0-beta.3 is now available 👀😲

@sjnonweb

This comment has been minimized.

@Ne3l

This comment has been minimized.

@aleclarson

This comment has been minimized.

@aleclarson

This comment has been minimized.

@phaistonian
Copy link

@aleclarson Is this scheduled to be fixed in 9.x?

@aleclarson
Copy link
Contributor Author

@phaistonian Getting a 404 on your link

@Nantris
Copy link

Nantris commented Feb 1, 2020

@aleclarson works for me (kind of.) Trying to fork it fails, so I can't see if the issue exists in beta.34. The link is using a canary build, 808.12

Error it shows is Cannot animate to the given "to" prop, because the current value has a different type

Gist of the code

@aleclarson
Copy link
Contributor Author

aleclarson commented Feb 1, 2020

Sounds like #867, which is fixed in the latest canary.

@minikomi
Copy link

minikomi commented Feb 7, 2020

I'm playing around with chaining transitions using async/await. I have something working on v.8:

https://codesandbox.io/s/dazzling-swartz-2fcn4

but changing to v.9 causes the enter animation to sporadically not fire:

https://codesandbox.io/s/crazy-leakey-lr5ve

Looks like this is fixed using the new canary & new useTransition API.

@jjang16
Copy link

jjang16 commented Feb 10, 2020

setting ref for RenderProps api breaks for beta.34

  import { Spring } from 'react-spring'
// ...
  const ref = React.useRef(null)
// ...
  return (
    <Spring ref={ref}
     {...}>
     {...}
    </Spring>
  )

Warning: Function components cannot be given refs. Attempts to access this ref will fail.

is setting ref for renderProps api deprecated?
or is there any other way to get the controller from the component?

@aleclarson
Copy link
Contributor Author

@jjang16 Please try with the latest canary. 👍

@wbobeirne
Copy link

Running into an issue in combination with #601, if you're using typescript and you add .cjs to your import to get the commonjs version, you don't get the types because it's expecting a .cjs.d.ts file, and doesn't pickup the regular .d.ts file.

For what it's worth, I'm in agreement with the OP of #601 that exporting es modules by default is confusing for people to work around, and goes against what the majority of modules do.

@gtolarc
Copy link

gtolarc commented Mar 19, 2020

I agree with you. @wbobeirne Actually, I am having the same problem, and building by artificially adding cjs.d.ts file to solve it. (with nextjs v9 & react-spring v9) This was too confusing. So, basically, it is necessary to provide a cjs.d.ts file and describe the guide on the document or use the basic module as cjs. What do you think? @aleclarson

@NerdCowboy
Copy link

It appears there might be a regression of #910.

Using Gatsby, I upgraded to 9.0.0-beta.34 and getting the error, TypeError: Cannot read property 'isReactComponent' of undefined anytime I try gatsby build.

No issues when running gatsby develop though.

@aleclarson
Copy link
Contributor Author

@wbobeirne @gtolarc The .cjs.d.ts module will exist in the next canary. Thanks 👍

@NerdCowboy That hasn't been released under 9.0.0-beta yet, but the latest canary has it.

@Nantris
Copy link

Nantris commented Apr 4, 2020

When might another canary land? We're excited for React-Spring, but a few broken things have had us unable to use it. Sadly other things broken in v8 prevent us from using it either. Hope I don't sound ungrateful asking. React-Spring is just awesome and I'm excited and looking forward to implementing it.

@IngoValente
Copy link

IngoValente commented Apr 9, 2020

I'm getting some weird behaviour in the latest canaries, starting from the versions beginning with 809. Last version of the 808's works as expected.
Looks like the spring gets reset on a component rerender, see example here: https://codesandbox.io/s/initial-rocket-lubsl
Drag the red rectangle, then resize your window -> the rectangle will jump back to its initial position. Switch to the last 808 version, and it remains in the correct position.
Is this a change in the API I'm missing or a potential bug?

Scratch that. Looks like useSpring now has a dependency array to keep it from updating when not necessary:

const [{ x, y }, set] = useSpring(() => ({ x: 0, y: 0 }), [])

@aleclarson
Copy link
Contributor Author

@IngoValente Please open a new issue whose title starts with [808] and I'll check it out

@slapbox Have all the issues you encountered been reported? Canary coming in the next few days maybe.

@Nantris
Copy link

Nantris commented Apr 9, 2020

@aleclarson thanks for your response, count me among the excited! #922 is a showstopper for us. It's the only major bug I'm aware of.

@aleclarson
Copy link
Contributor Author

@IngoValente If your props function was being called on every render, that was fixed with 55c5691 in the 808.17 canary.

@slapbox I think there's a fix for that waiting to be released. Stay tuned!

@asfktz
Copy link

asfktz commented Apr 11, 2020

Hi,
I notice that decay is not working with v9.0.0-beta.34

See the rocket example in "React Use Gesture":
https://codesandbox.io/s/initial-rocket-8r4pn?file=/src/index.js

@SokichiFujita
Copy link

SokichiFujita commented Apr 17, 2020

This <animate> component's TypeScript error (TS3589) is still remaining in v9.0.0-beta.34 . #653 But it has been resolved in canary of v.9.0.0.

#653

@dlindenkreuz
Copy link

@asfktz
I notice that decay is not working with v9.0.0-beta.34
...
https://codesandbox.io/s/initial-rocket-8r4pn?file=/src/index.js

decay works fine for me.
get was renamed to getValue though 😉

# line 21
- { initial: () => pos.get() }
+ { initial: () => pos.getValue() }

@iagodahlem
Copy link

I found a bug using v9.0.0-beta.34 with the useTransition hook.

When I try to update any item of the array being passed as the first argument to useTransition, the items returned from the hook are never updated.

I used the List-Reordering example from the docs as a base for simulating the bug: https://codesandbox.io/s/usetransitionflip-1w1ul?file=/src/index.js

Try clicking on the "increase quantity" button on each item, you will see that the rows array is updated, but the transitions return from the hook never reflects those changes.

@brotzky
Copy link

brotzky commented May 6, 2020

@iagodahlem try a canary release. I think your issue has been solved: #949

@Nantris
Copy link

Nantris commented May 6, 2020

@iagodahlem @brotzky the latest canary available on npm is from January, but the PR is from March so it will be in the next canary.

@aleclarson aleclarson unpinned this issue May 6, 2020
@aleclarson
Copy link
Contributor Author

Replaced by #985

To those who reported an unsolved issue: Please reproduce it using v9.0.0-rc.1, then open a new issue with your report. Thanks! 👍

@pmndrs pmndrs locked and limited conversation to collaborators May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests