Bugfix: make animated work with arrow function component
#910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wow, that's very weird.. 🤯 |
aleclarson
reviewed
Jan 24, 2020
chenesan
force-pushed
the
bugfix/animated-should-work-with-arrow-func-component
branch
from
08ea8fa to
c4d4cf0
Compare
When we pass arrow function component, it will throw error because in `createAnimatedComponent` we check `Component.prototype.isReactComponent` to check if it's component created by `create-react-class`, but arrow function doesn't have `.prototype` property. This commit additionally check if `.prototype` exists.
chenesan
force-pushed
the
bugfix/animated-should-work-with-arrow-func-component
branch
from
c4d4cf0 to
a2d71a7
Compare
|
Thanks @chenesan 🎉 |
chenesan
deleted the
bugfix/animated-should-work-with-arrow-func-component
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found out this bug when I'm working on #903: When we pass arrow function component, it will throw error because in
createAnimatedComponentwe checkComponent.prototype.isReactComponentto check if it's component created bycreate-react-class, but arrow function doesn't have.prototypeproperty. This commit additionally check if.prototypeexists to make arrow function component can work withanimated().To test this just try to pass an arrow function component into
animated().