Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add possibility to get the ServicePrincipal via IAppManager #1116

Merged

Conversation

mloitzl
Copy link
Contributor

@mloitzl mloitzl commented Feb 25, 2023

@codecov-commenter
Copy link

Codecov Report

Base: 82.42% // Head: 84.21% // Increases project coverage by +1.79% 🎉

Coverage data is based on head (0f4392c) compared to base (63545f3).
Patch has no changes to coverable lines.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #1116      +/-   ##
==========================================
+ Coverage   82.42%   84.21%   +1.79%     
==========================================
  Files         416      608     +192     
  Lines       28590    41565   +12975     
==========================================
+ Hits        23565    35005   +11440     
- Misses       5025     6560    +1535     
Impacted Files Coverage Δ
...re/Model/SharePoint/Changes/Internal/ChangeUser.cs 0.00% <0.00%> (-100.00%) ⬇️
...k/PnP.Core/Model/Teams/Internal/TeamChatMessage.cs 72.34% <0.00%> (-27.66%) ⬇️
...odel/Security/Internal/SharePointUserCollection.cs 78.78% <0.00%> (-21.22%) ⬇️
...ore.Auth/Utilities/ApplicationBuilderExtensions.cs 43.90% <0.00%> (-18.17%) ⬇️
.../SharePoint/Core/Internal/ContentTypeCollection.cs 84.69% <0.00%> (-15.31%) ⬇️
src/sdk/PnP.Core/Services/Core/TestManager.cs 53.19% <0.00%> (-14.71%) ⬇️
...PnP.Core.Admin/Model/Teams/Internal/TeamCreator.cs 76.19% <0.00%> (-14.29%) ⬇️
...e/Model/Teams/Internal/TeamChannelTabCollection.cs 87.92% <0.00%> (-12.08%) ⬇️
...k/PnP.Core/Model/SharePoint/Core/Internal/Field.cs 81.60% <0.00%> (-11.25%) ⬇️
.../Model/SharePoint/Core/Internal/ListItemVersion.cs 66.66% <0.00%> (-11.12%) ⬇️
... and 319 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jansenbe jansenbe self-assigned this Feb 27, 2023
jansenbe added a commit that referenced this pull request Feb 27, 2023
@jansenbe jansenbe merged commit 5073143 into pnp:dev Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants