Add possibility to get the ServicePrincipal via IAppManager

docs/using-the-sdk/admin-sharepoint-apps.md

@@ -181,14 +181,14 @@ After adding and deploying an app to the app catalog these API permissions need
 
 ```csharp
 // List the permission requests that are pending approval or rejection
-ServicePrincipal principal = new(context);
-List<IPermissionRequest> permissionRequests = await principal.GetPermissionRequestsAsync();
+var appManager = context.GetTenantAppManager();
+List<IPermissionRequest> permissionRequests = await appManager.ServicePrincipal.GetPermissionRequestsAsync();
 
 // Approve a permission request
-var result = await principal.ApprovePermissionRequestAsync(permissionRequests.First().Id.ToString());
+var result = await appManager.ServicePrincipal.ApprovePermissionRequestAsync(permissionRequests.First().Id.ToString());
 
 // Deny a permission request
-await principal.DenyPermissionRequestAsync(permissionRequests.First().Id.ToString());
+await appManager.ServicePrincipal.DenyPermissionRequestAsync(permissionRequests.First().Id.ToString());
 ```
 
 ## Tenant app catalog specific operations

src/sdk/PnP.Core.Admin.Test/SharePoint/PermissionRequestsTests.cs

@@ -83,10 +83,14 @@ public async Task ApprovePermissionsRequestTest_Async()
                     app = appManager.Add(packagePath, true);
                     var deployResult = app.Deploy(false);
 
-                    ServicePrincipal principal = new(context);
-                    List<IPermissionRequest> permissionRequests = await principal.GetPermissionRequestsAsync();
+                    Assert.IsTrue(deployResult);
 
-                    var result = await principal.ApprovePermissionRequestAsync(permissionRequests.First().Id.ToString());
+                    List<IPermissionRequest> permissionRequests =
+                        await appManager.ServicePrincipal.GetPermissionRequestsAsync();
+
+                    var result =
+                        await appManager.ServicePrincipal.ApprovePermissionRequestAsync(permissionRequests.First().Id
+                            .ToString());
 
                     Assert.IsNotNull(result);
                     Assert.IsTrue(!string.IsNullOrWhiteSpace(result.ObjectId));
@@ -105,12 +109,27 @@ public async Task GetPermissionsRequestsTest_Async()
             //TestCommon.Instance.Mocking = false;
             using (PnPContext context = await TestCommon.Instance.GetContextAsync(TestCommonBase.TestSite))
             {
-                ServicePrincipal principal = new(context);
-                List<IPermissionRequest> permissionRequests = await principal.GetPermissionRequestsAsync();
+                ITenantApp app = null;
+                try
+                {
+                    var appManager = context.GetTenantAppManager();
+                    app = appManager.Add(packagePath, true);
+                    var deployResult = app.Deploy(false);
+
+                    Assert.IsTrue(deployResult);
+
+                    List<IPermissionRequest> permissionRequests =
+                        await appManager.ServicePrincipal.GetPermissionRequestsAsync();
 
                 Assert.IsNotNull(permissionRequests);
                 Assert.IsTrue(permissionRequests.Count > 0);
             }
+                finally
+                {
+                    var retractResult = app.Retract();
+                    app.Remove();
+                }
+            }
         }
 
         [TestMethod]
@@ -125,10 +144,14 @@ public async Task DenyPermissionsRequestTest_Async()
                     var appManager = context.GetTenantAppManager();
                     app = appManager.Add(packagePath, true);
                     var deployResult = app.Deploy(false);
-                    ServicePrincipal principal = new(context);
-                    List<IPermissionRequest> permissionRequests = await principal.GetPermissionRequestsAsync();
 
-                    await principal.DenyPermissionRequestAsync(permissionRequests.First().Id.ToString());
+                    Assert.IsTrue(deployResult);
+
+                    List<IPermissionRequest> permissionRequests =
+                        await appManager.ServicePrincipal.GetPermissionRequestsAsync();
+
+                    await appManager.ServicePrincipal.DenyPermissionRequestAsync(permissionRequests.First().Id
+                        .ToString());
                 }
                 finally
                 {

src/sdk/PnP.Core.Admin/Model/SharePoint/Core/Internal/AppManager.cs

@@ -242,6 +242,14 @@ public async Task<T> AddAsync(string path, bool overwrite = false)
             return await AddAsync(bytes, fileInfo.Name, overwrite).ConfigureAwait(false);
         }
 
+        public IServicePrincipal ServicePrincipal
+        {
+            get
+            {
+                return new ServicePrincipal(this.context);
+            }
+        }
+
         /// <summary>
         /// Executes an action and disposes <see cref="PnPContext" /> if it's not the current context
         /// </summary>

src/sdk/PnP.Core.Admin/Model/SharePoint/Core/Public/IAppManager.cs

@@ -82,5 +82,10 @@ public interface IAppManager<T> : IAppOperations where T : IApp
         /// <param name="overwrite">If true will overwrite an existing entry.</param>
         /// <returns>An instance of the app.</returns>
         Task<T> AddAsync(string path, bool overwrite = false);
+
+        /// <summary>
+        /// Get the SharePoint Apps ServicePrincipal
+        /// </summary>
+        IServicePrincipal ServicePrincipal { get; }
     }
 }