-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests fail in master with aiohttp==3.7.0, "TypeError" #173
Comments
tseaver
added a commit
to googleapis/google-auth-library-python
that referenced
this issue
Oct 26, 2020
Working around breaking change in 3.7.0. See: pnuckowski/aioresponses#173
gcf-merge-on-green bot
pushed a commit
to googleapis/google-auth-library-python
that referenced
this issue
Oct 27, 2020
Working around breaking change in 3.7.0. See: pnuckowski/aioresponses#173
Hey, when will this patch be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running tests for the current head of master gives me
All the failing tests have a traceback similar to the following:
The new version 3.7.0 of aiohttp has changed the signature for the StreamReader class, making the limit argument required.
https://github.com/aio-libs/aiohttp/blob/56e78836aa7c67292ace9e256711699d51d57285/aiohttp/streams.py#L106
The text was updated successfully, but these errors were encountered: