Fix compatibility with aiohttp==3.7.0 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #174 +/- ##
=======================================
Coverage 97.95% 97.95%
=======================================
Files 2 2
Lines 294 294
=======================================
Hits 288 288
Misses 6 6
Continue to review full report at Codecov.
|
The new version of aiohttp has made `limit` a required argument for the StreamReader class. This change adds an explicit limit of 2 ** 16 which is the same as what aiohttp uses internally. Using `limit` as a keyword (rather than a positional argument) keeps compatibility with previous versions of aiohttp. Fixes #173
ajcolaizzi-decentrix
approved these changes
Oct 26, 2020
|
@davidwtbuxton Thanks for the fix, we are running into this locally now. Any idea when this will be released? |
gaffney
added a commit
to lunacare/aioresponses
that referenced
this pull request
Oct 26, 2020
jayvdb
approved these changes
Oct 28, 2020
|
ping @pnuckowski |
|
thx @pnuckowski . Could you tag and release this one soon. It is breaking CI for other projects. |
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new version of aiohttp has made
limita required argument for theStreamReader class. This change adds an explicit limit of 2 ** 16 which
is the same as what aiohttp uses internally.
Fixes #173