Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Feature) Select input for Boolean type for contract type acc #229

Merged
merged 13 commits into from
Dec 26, 2018
Merged

(Feature) Select input for Boolean type for contract type acc #229

merged 13 commits into from
Dec 26, 2018

Conversation

vbaranov
Copy link
Collaborator

screen shot 2018-12-19 at 19 52 25

Based on #219

@ghost ghost assigned vbaranov Dec 19, 2018
@ghost ghost added the in progress label Dec 19, 2018
@dennis00010011b
Copy link

@vbaranov
Execute method: parameter field doesn't allow input for functions with no boolean return
screen shot 2018-12-19 at 09 31 35

@dennis00010011b dennis00010011b mentioned this pull request Dec 20, 2018
Merged
@vbaranov
Copy link
Collaborator Author

Execute method: parameter field doesn't allow input for functions with no boolean return

Thanks, @dennis00010011b. Fixed here 2f89dfc

@vbaranov vbaranov added this to the NW release 4.10.1 milestone Dec 20, 2018
fvictorio
fvictorio reviewed Dec 21, 2018
View reviewed changes
old-ui/app/components/send/send-contract.js Outdated
if (params.type === 'bool' && isInput) {
field = (
<SendTransactionInputSelect
key={Math.random()}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this necesssary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, key prop is not necessary for inputs. Removed, thanks @fvictorio

@vbaranov vbaranov merged commit 67466de into develop Dec 26, 2018
@vbaranov vbaranov deleted the bool-select branch December 26, 2018 13:10
@ghost ghost removed the awaiting for review label Dec 26, 2018
@vbaranov vbaranov mentioned this pull request Dec 29, 2018
Merged
@snyk-bot snyk-bot mentioned this pull request Jul 28, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fvictorio fvictorio fvictorio left review comments

@dennis00010011b dennis00010011b dennis00010011b approved these changes

@patitonar patitonar patitonar approved these changes

@fernandomg fernandomg Awaiting requested review from fernandomg

Assignees

@vbaranov vbaranov

@dennis00010011b dennis00010011b

Labels
e2e tests are affected
Projects
None yet
Milestone
NW release 4.10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@vbaranov @dennis00010011b @fvictorio @patitonar