forked from MetaMask/metamask-extension
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Feature) Select input for Boolean type for contract type acc #229
Merged
Merged
Changes from 3 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
77d42f3
Select in put for boolean type
vbaranov fcfb3e6
Select for bollean in interactions with smart-contracts
vbaranov c79358f
e2e: execute method boolean dropdown
dennis00010011b a383d56
e2e:install lastest chrome
dennis00010011b 8028070
e2e:lintt fix
dennis00010011b 2f89dfc
onChange input handler fix
vbaranov b67cc62
e2e: remove comment
dennis00010011b 22bb4f5
e2e: sync upstream
dennis00010011b a4ca71c
Merge pull request #230 from dennis00010011b/e2e-bool-select
vbaranov eccf47c
merge with develop branch
vbaranov a8bc885
merge with develop branch
vbaranov c499a78
remove key prop from bool input
vbaranov 42f2af1
Merge branch 'develop' into bool-select
vbaranov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necesssary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed,
key
prop is not necessary for inputs. Removed, thanks @fvictorio