Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove lodash.merge #157

Merged
merged 2 commits into from
Jul 21, 2020
Merged

fix: Remove lodash.merge #157

merged 2 commits into from
Jul 21, 2020

Conversation

trygve-lie
Copy link
Contributor

Replace lodash.merge with plain object destructuring.

lib/layout.js Outdated Show resolved Hide resolved
lib/layout.js Outdated Show resolved Hide resolved
lib/layout.js Outdated Show resolved Hide resolved
@trygve-lie trygve-lie merged commit ea2bc77 into next Jul 21, 2020
@trygve-lie trygve-lie deleted the no-merge branch July 21, 2020 10:35
github-actions bot pushed a commit that referenced this pull request Jul 21, 2020
# [5.0.0-next.3](v5.0.0-next.2...v5.0.0-next.3) (2020-07-21)

### Bug Fixes

* Remove lodash.merge ([#157](#157)) ([ea2bc77](ea2bc77))
@github-actions
Copy link

🎉 This PR is included in version 5.0.0-next.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
# [5.0.0](v4.6.125...v5.0.0) (2023-11-29)

### Bug Fixes

* Remove lodash.merge ([#157](#157)) ([ea2bc77](ea2bc77))
* Resolve merge conflicts ([be49970](be49970))
* Use latest client and proxy ([#399](#399)) ([4035461](4035461))

### Features

* Convert to ESM ([#286](#286)) ([7824568](7824568))
* Drop node 10.x support ([7e0bb22](7e0bb22))
* Remove deprecated return value on .js and .css methods ([e9052ed](e9052ed))

### BREAKING CHANGES

* Convert from CommonJS module to ESM

* fix: Set type to be module

Co-authored-by: Trygve Lie <trygve.lie@finn.no>
* In version 4 of podium it became possible to set multiple assets to a layout through its `.js()` and `.css()` methods. This did make it impossible to let these methods return a reasonable value, but to keep a backwards compatibility with version 3 of Podium, the first item passed in was returned for compatibility. This removes this compatibility with version 3 of Podium.

This resolves podium-lib/issues#23
* Only support node 12 and 14.
Copy link

🎉 This PR is included in version 5.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants