Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register test observer in main queue #834

Merged

Conversation

MarkVillacampa
Copy link
Contributor

Fixes a crash when calling [XCTestObservationCenter addTestObserver:] that would fail an assertion: 'Test observers can only be registered and unregistered on the main thread.'

Fixes: #661

@MarkVillacampa MarkVillacampa force-pushed the register-observer-main-queue branch from 206370d to e1b4229 Compare February 29, 2024 23:38
@stephencelis stephencelis merged commit c81750d into pointfreeco:main Apr 5, 2024
JustasL added a commit to vinted/swift-snapshot-testing that referenced this pull request May 28, 2024
* main:
  Make ViewImageConfig Sendable (pointfreeco#850)
  Added mention of, and link to plugin SnapshotVision. (pointfreeco#848)
  Run swift-format
  Register test observer in main queue (pointfreeco#834)
  Ability to remove inline snapshots (pointfreeco#844)
  Bump swift-syntax to 5.10.0 (pointfreeco#836)
  Fix indentation parsing (pointfreeco#830)
  Fixing wkWebView.takeSnapshot with Xcode 14 & 15 (pointfreeco#692)
  Run swift-format
  Non-Metal based perceptual image comparison (pointfreeco#666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests don't run and crash with error
2 participants