Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to remove inline snapshots #844

Merged
merged 3 commits into from
Apr 5, 2024
Merged

Conversation

stephencelis
Copy link
Member

This updates assertInlineSnapshot to match against an optional, so that when nil is provided, the snapshot helper can scrub the trailing snapshot closure.

This can be used by downstream helpers, like assertMacro to "un-record" certain snapshots when it makes sense to: e.g. when removing an expansion and recording a new diagnostic instead.

@stephencelis stephencelis requested a review from mbrandonw April 5, 2024 20:07
@stephencelis stephencelis merged commit 7083a44 into main Apr 5, 2024
3 checks passed
@stephencelis stephencelis deleted the inline-snapshot-removal branch April 5, 2024 20:38
JustasL added a commit to vinted/swift-snapshot-testing that referenced this pull request May 28, 2024
* main:
  Make ViewImageConfig Sendable (pointfreeco#850)
  Added mention of, and link to plugin SnapshotVision. (pointfreeco#848)
  Run swift-format
  Register test observer in main queue (pointfreeco#834)
  Ability to remove inline snapshots (pointfreeco#844)
  Bump swift-syntax to 5.10.0 (pointfreeco#836)
  Fix indentation parsing (pointfreeco#830)
  Fixing wkWebView.takeSnapshot with Xcode 14 & 15 (pointfreeco#692)
  Run swift-format
  Non-Metal based perceptual image comparison (pointfreeco#666)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants