feat(python)!: Change Series.shuffle default behaviour (#5991)

pola-rs · Jan 26, 2023 · 8f8b7e7 · 8f8b7e7
1 parent cfa8dbe
commit 8f8b7e7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 12 deletions.
diff --git a/py-polars/polars/internals/expr/expr.py b/py-polars/polars/internals/expr/expr.py
@@ -5314,7 +5314,7 @@ def reshape(self, dims: tuple[int, ...]) -> Expr:
 
     def shuffle(self, seed: int | None = None) -> Expr:
         """
-        Shuffle the contents of this expr.
+        Shuffle the contents of this expression.
 
         Parameters
         ----------

diff --git a/py-polars/polars/internals/series/series.py b/py-polars/polars/internals/series/series.py
@@ -14,7 +14,6 @@
     Union,
     overload,
 )
-from warnings import warn
 
 from polars import internals as pli
 from polars.datatypes import (
@@ -4604,7 +4603,8 @@ def shuffle(self, seed: int | None = None) -> Series:
         Parameters
         ----------
         seed
-            Seed for the random number generator.
+            Seed for the random number generator. If set to None (default), a random
+            seed is generated using the ``random`` module.
 
         Examples
         --------
@@ -4619,15 +4619,6 @@ def shuffle(self, seed: int | None = None) -> Series:
         ]
 
         """
-        if seed is None:
-            warn(
-                "Series.shuffle will default to a random seed in a future version."
-                " Provide a value for the seed argument to silence this warning.",
-                DeprecationWarning,
-                stacklevel=2,
-            )
-            seed = 0
-        return self.to_frame().select(pli.col(self.name).shuffle(seed)).to_series()
 
     def ewm_mean(
         self,