Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python)!: Change Series.shuffle default behaviour #5991

Merged
merged 1 commit into from
Jan 26, 2023
Merged

feat(python)!: Change Series.shuffle default behaviour #5991

merged 1 commit into from
Jan 26, 2023

Conversation

stinodego
Copy link
Member

@stinodego stinodego commented Jan 2, 2023 •
edited
Loading

!! THIS IS A BREAKING CHANGE !!

Changes:

  • Change Series.shuffle default behaviour to use a random seed if seed argument is not provided.
  • Dispatch Series.shuffle to Expr.shuffle

Another one for the next breaking release 😸

@github-actions github-actions bot added breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars labels Jan 2, 2023
@ritchie46 ritchie46 merged commit 8f8b7e7 into pola-rs:master Jan 26, 2023
@stinodego stinodego deleted the break-shuffle branch February 22, 2023 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Change that breaks backwards compatibility enhancement New feature or an improvement of an existing feature python Related to Python Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @ritchie46