Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]: Fix coverage calculation in CI #14689

Closed
wants to merge 1 commit into from

Conversation

c-peters
Copy link
Collaborator

No description provided.

@c-peters c-peters marked this pull request as draft February 25, 2024 18:20
@c-peters c-peters self-assigned this Feb 26, 2024
@c-peters c-peters added the accepted Ready for implementation label Feb 26, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.06%. Comparing base (0e63403) to head (03c7f45).
Report is 24 commits behind head on main.

❗ Current head 03c7f45 differs from pull request most recent head 0551734. Consider uploading reports for the commit 0551734 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14689      +/-   ##
==========================================
+ Coverage   80.92%   81.06%   +0.13%     
==========================================
  Files        1328     1322       -6     
  Lines      173446   171348    -2098     
  Branches     2455     2460       +5     
==========================================
- Hits       140369   138905    -1464     
+ Misses      32605    31973     -632     
+ Partials      472      470       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion
Copy link
Collaborator

Limiting CMAKE_BUILD_PARALLEL_LEVEL seems to work (I tried 10) while keeping zlib-ng - https://github.com/pola-rs/polars/actions/runs/8063282434/job/22024774215?pr=14715.

I think this is also be the same reason why the python release is failing for the macOS workflows.

@c-peters
Copy link
Collaborator Author

Limiting CMAKE_BUILD_PARALLEL_LEVEL seems to work (I tried 10) while keeping zlib-ng - https://github.com/pola-rs/polars/actions/runs/8063282434/job/22024774215?pr=14715.

I think this is also be the same reason why the python release is failing for the macOS workflows.

Great! Could not find how to alter the cmake build, but that was exactly what I was looking for!

trigger ci

change runner

lower jobs

nightly

build cmd

brew install zlib

less packages

override env

change flag

testing

simplify

simplify

simplify

simplify

simplify

simplify2

temp remove zlib-ng

simplify

simplify

simplify

simplify

simplify

simplify

simplify
@c-peters
Copy link
Collaborator Author

Closing this in favor of #14715

@c-peters c-peters closed this Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants