-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Limit CMake threads to fix crash compiling libz-ng-sys
on macOS
#14715
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14715 +/- ##
==========================================
+ Coverage 80.92% 81.07% +0.14%
==========================================
Files 1328 1322 -6
Lines 173446 171348 -2098
Branches 2455 2460 +5
==========================================
- Hits 140369 138915 -1454
+ Misses 32605 31963 -642
+ Partials 472 470 -2 ☔ View full report in Codecov by Sentry. |
4e0f7a2
to
4c2e698
Compare
libz-ng-sys
on macOS
libz-ng-sys
on macOSlibz-ng-sys
on macOS
libz-ng-sys
on macOSlibz-ng-sys
on macOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the fix!
So is this an issue with libz-ng-sys
? If so, is there an issue in their repo we can point to in the comments rather than this PR?
Not entirely sure, and I don't see anything related in their issues yet.. (if this is the right place https://github.com/rust-lang/libz-sys/issues?q=sort%3Aupdated-desc). I won't be able to make a repro as well since I don't own a mac 🫠 |
All right. I made a minor adjustment by only setting this environment variable for the MacOS release flow. Good to merge 👍 |
Presumably spawned too many threads