Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Don't run streaming group-by in partitionable gb #15611

Merged
merged 2 commits into from
Apr 12, 2024
Merged

Conversation

ritchie46
Copy link
Member

@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Apr 12, 2024
@stinodego
Copy link
Member

Great. That means that POLARS_NO_STREAMING_GROUPBY is no longer used, right? There's a test that explicitly sets this, we can remove the monkeypatch there.

Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #15611 will degrade performances by 15.23%

Comparing streaming (406b68e) with main (c068e76)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 20 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main streaming Change
test_h2oai_groupby_q1 6.5 s 5.3 s +24.08%
test_h2oai_groupby_q4 5.7 s 6.7 s -15.23%

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.25%. Comparing base (c068e76) to head (406b68e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15611      +/-   ##
==========================================
+ Coverage   81.20%   81.25%   +0.04%     
==========================================
  Files        1371     1371              
  Lines      175822   175772      -50     
  Branches     2531     2531              
==========================================
+ Hits       142782   142824      +42     
+ Misses      32563    32471      -92     
  Partials      477      477              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 92902e6 into main Apr 12, 2024
23 of 24 checks passed
@ritchie46 ritchie46 deleted the streaming branch April 12, 2024 15:02
@c-peters c-peters added the accepted Ready for implementation label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants