Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mean of boolean in streaming group_by incorrectly always gave NULL #15616

Merged
merged 3 commits into from
Apr 13, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Apr 12, 2024

Fixes #15610

This also happened non-deterministically on the standard engine as it sometimes ran streaming, but that will probably change soon with #15611

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 12, 2024
@nameexhaustion nameexhaustion changed the title fix: Mean of boolean in streaming group_by incorrectly gave NULL fix: Mean of boolean in streaming group_by incorrectly always gave NULL Apr 12, 2024
Copy link

codspeed-hq bot commented Apr 12, 2024

CodSpeed Performance Report

Merging #15616 will not alter performance

Comparing nameexhaustion:bool-mean (f3731a4) with main (92902e6)

Summary

✅ 22 untouched benchmarks

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.26%. Comparing base (c068e76) to head (f3731a4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #15616      +/-   ##
==========================================
+ Coverage   81.20%   81.26%   +0.06%     
==========================================
  Files        1371     1371              
  Lines      175822   175773      -49     
  Branches     2531     2531              
==========================================
+ Hits       142782   142848      +66     
+ Misses      32563    32450     -113     
+ Partials      477      475       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit b09a709 into pola-rs:main Apr 13, 2024
24 checks passed
@nameexhaustion nameexhaustion deleted the bool-mean branch April 13, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mean of bool column in .agg() during .group_by() retruns Null - Example
2 participants