Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rust,python): Fix GC logic in write_ipc #17752

Merged
merged 1 commit into from
Jul 21, 2024
Merged

Conversation

ruihe774
Copy link
Contributor

#17627 changed the logic of maybe_gc(), which was used in write_ipc(). GC might not be performed for arrays with multiple references when writing ipc files, which could result in huge files. This PR fixes it. write_ipc() now decide whether to gc or not based on total_bytes_len() and total_buffer_len().

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Jul 20, 2024
Copy link

codecov bot commented Jul 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.41%. Comparing base (7015663) to head (b3d84cb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17752      +/-   ##
==========================================
- Coverage   80.43%   80.41%   -0.02%     
==========================================
  Files        1502     1502              
  Lines      197035   197048      +13     
  Branches     2794     2794              
==========================================
- Hits       158482   158461      -21     
- Misses      38039    38073      +34     
  Partials      514      514              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46
Copy link
Member

Nice one. That's a observation.

@ritchie46 ritchie46 merged commit 9d4a4e9 into pola-rs:main Jul 21, 2024
21 checks passed
atigbadr pushed a commit to atigbadr/polars that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants