Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rust,python): Fix GC logic in write_ipc #17752

Merged
merged 1 commit into from
Jul 21, 2024
Merged

fix(rust,python): Fix GC logic in write_ipc #17752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions crates/polars-arrow/src/io/ipc/write/common.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,6 +265,22 @@ fn set_variadic_buffer_counts(counts: &mut Vec<i64>, array: &dyn Array) {
}
}

fn gc_bin_view<'a, T: ViewType + ?Sized>(
arr: &'a Box<dyn Array>,
concrete_arr: &'a BinaryViewArrayGeneric<T>,
) -> Cow<'a, Box<dyn Array>> {
let bytes_len = concrete_arr.total_bytes_len();
let buffer_len = concrete_arr.total_buffer_len();
let extra_len = buffer_len.saturating_sub(bytes_len);
if extra_len < bytes_len.min(1024) {
// We can afford some tiny waste.
Cow::Borrowed(arr)
} else {
// Force GC it.
Cow::Owned(concrete_arr.clone().gc().boxed())
}
}

/// Write [`RecordBatchT`] into two sets of bytes, one for the header (ipc::Schema::Message) and the
/// other for the batch's data
fn chunk_to_bytes_amortized(
Expand All @@ -284,19 +300,11 @@ fn chunk_to_bytes_amortized(
let array = match array.data_type() {
ArrowDataType::BinaryView => {
let concrete_arr = array.as_any().downcast_ref::<BinaryViewArray>().unwrap();
if concrete_arr.is_sliced() {
Cow::Owned(concrete_arr.clone().maybe_gc().boxed())
} else {
Cow::Borrowed(array)
}
gc_bin_view(array, concrete_arr)
},
ArrowDataType::Utf8View => {
let concrete_arr = array.as_any().downcast_ref::<Utf8ViewArray>().unwrap();
if concrete_arr.is_sliced() {
Cow::Owned(concrete_arr.clone().maybe_gc().boxed())
} else {
Cow::Borrowed(array)
}
gc_bin_view(array, concrete_arr)
},
_ => Cow::Borrowed(array),
};
Expand Down