perf: Remove async directory auto-detection #17779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
nameexhaustion
changed the title
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17779 +/- ##
==========================================
+ Coverage 80.42% 80.46% +0.04%
==========================================
Files 1502 1502
Lines 197075 197074 -1
Branches 2794 2794
==========================================
+ Hits 158498 158584 +86
+ Misses 38063 37976 -87
Partials 514 514 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This functionality requires we send 1 HEAD request per path in a serial manner - which can be extremely slow if the user provides a list of cloud file paths. This PR makes it so that an explicit trailing slash must be given if you want to scan from a cloud directory, which also matches the behavior of AWS CLI and improves performance.