Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Remove async directory auto-detection #17779

Merged
merged 3 commits into from
Jul 22, 2024
Merged

perf: Remove async directory auto-detection #17779

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3ed1743
perf: Don't send head request unless without explicit trailing slash
nameexhaustion Jul 22, 2024
759579c
c
nameexhaustion Jul 22, 2024
af1b949
add comment
nameexhaustion Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions crates/polars-io/src/path_utils/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,10 +174,13 @@ pub fn expand_paths_hive(

let prefix = object_path_from_string(cloud_location.prefix.clone())?;

let out = if !path.ends_with("/")
&& cloud_location.expansion.is_none()
&& store.head(&prefix).await.is_ok()
{
let out = if !path.ends_with("/") && cloud_location.expansion.is_none() && {
ritchie46 marked this conversation as resolved.
Show resolved Hide resolved
// We need to check if it is a directory for local paths (we can be here due
// to FORCE_ASYNC). For cloud paths the convention is that the user must add
// a trailing slash `/` to scan directories. We don't infer it as that would
// mean sending one network request per path serially (very slow).
is_cloud || PathBuf::from(path).is_file()
} {
(
0,
vec![PathBuf::from(format_path(
Expand Down