Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Push down slice with non-zero offset to Parquet #17972

Merged
merged 4 commits into from
Aug 1, 2024
Merged

perf: Push down slice with non-zero offset to Parquet #17972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
47cefd8
c
nameexhaustion Aug 1, 2024
f43d9c3
c
nameexhaustion Aug 1, 2024
2ed49c9
c
nameexhaustion Aug 1, 2024
5adcf88
c
nameexhaustion Aug 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 7 additions & 12 deletions crates/polars-io/src/parquet/read/async_impl.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ use tokio::sync::Mutex;

use super::mmap::ColumnStore;
use super::predicates::read_this_row_group;
use super::read_impl::compute_row_group_range;
use crate::cloud::{
build_object_store, object_path_from_str, CloudLocation, CloudOptions, PolarsObjectStore,
};
Expand Down Expand Up @@ -262,8 +261,8 @@ impl FetchRowGroupsFromObjectStore {
schema: ArrowSchemaRef,
projection: Option<&[usize]>,
predicate: Option<Arc<dyn PhysicalIoExpr>>,
row_group_range: Range<usize>,
row_groups: &[RowGroupMetaData],
limit: usize,
) -> PolarsResult<Self> {
let projected_fields: Option<Arc<[SmartString]>> = projection.map(|projection| {
projection
Expand All @@ -272,26 +271,22 @@ impl FetchRowGroupsFromObjectStore {
.collect()
});

let row_groups_end = compute_row_group_range(0, row_groups.len(), limit, row_groups);
let row_groups = &row_groups[0..row_groups_end];

let mut prefetched: PlHashMap<usize, DownloadedRowGroup> = PlHashMap::new();

let mut row_groups = if let Some(pred) = predicate.as_deref() {
row_groups
.iter()
.enumerate()
.filter(|(i, rg)| {
row_group_range
.filter_map(|i| {
let rg = &row_groups[i];
let should_be_read =
matches!(read_this_row_group(Some(pred), rg, &schema), Ok(true));

// Already add the row groups that will be skipped to the prefetched data.
if !should_be_read {
prefetched.insert(*i, Default::default());
prefetched.insert(i, Default::default());
}
should_be_read

should_be_read.then(|| (i, rg.clone()))
})
.map(|(i, rg)| (i, rg.clone()))
.collect::<Vec<_>>()
} else {
row_groups.iter().cloned().enumerate().collect()
Expand Down
Loading