fix: Infer reshape dims when determining schema #18923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the `reshape` function to properly infer dimensions in the schema. I did this by adding a "zero-cost" `ReshapeDimension` enum that can either be `Specified(u64)` or `Infer`. This also makes the reshaping behavior more consistent as now all negative values are always assumed to be `Infer`. During this work, I saw an unneeded allocation in `reshape_array` and removed it. Fixes pola-rs#18879.
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
github-actions
bot
added
fix
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18923 +/- ##
==========================================
- Coverage 79.89% 79.87% -0.02%
==========================================
Files 1520 1522 +2
Lines 206552 206943 +391
Branches 2906 2906
==========================================
+ Hits 165020 165299 +279
- Misses 40984 41096 +112
Partials 548 548 ☔ View full report in Codecov by Sentry. |
ritchie46
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
reshapefunction to properly infer dimensions in the schema.I did this by adding a "zero-cost"
ReshapeDimensionenum that can either beSpecified(u64)orInfer. This also makes the reshaping behavior more consistent as now all negative values are always assumed to beInfer.During this work, I saw an unneeded allocation in
reshape_arrayand removed it.Fixes #18879.