Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Infer reshape dims when determining schema #18923

Merged
merged 2 commits into from
Sep 26, 2024
Merged

fix: Infer reshape dims when determining schema #18923

merged 2 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. fix: Infer reshape dims when determining schema 

    This fixes the `reshape` function to properly infer dimensions in the schema.

I did this by adding a "zero-cost" `ReshapeDimension` enum that can either be
`Specified(u64)` or `Infer`. This also makes the reshaping behavior more
consistent as now all negative values are always assumed to be `Infer`.

During this work, I saw an unneeded allocation in `reshape_array` and removed
it.

Fixes pola-rs#18879.
    @coastalwhite
    coastalwhite committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    d1473f1 View commit details
    Browse the repository at this point in the history

  2. add missing file

    @coastalwhite
    coastalwhite committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    0d51ff8 View commit details
    Browse the repository at this point in the history