Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Implement nested row encoding / decoding #19874

Merged
merged 15 commits into from
Nov 22, 2024

Conversation

coastalwhite
Copy link
Collaborator

@coastalwhite coastalwhite commented Nov 19, 2024

This adds row encoding and decoding for nested types.

It is now possible to properly roundtrip pl.List, pl.Array and pl.Struct including their outer and inner validities through the row encoding en decoding.

Fixes #10747.

@coastalwhite coastalwhite changed the title get started on nested row encoding refactor: Implement nested row encoding / decoding Nov 20, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars and removed title needs formatting labels Nov 20, 2024
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 86.45598% with 120 lines in your changes missing coverage. Please review.

Project coverage is 79.48%. Comparing base (426cf27) to head (2e5d2c4).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-row/src/encode.rs 83.38% 99 Missing ⚠️
crates/polars-row/src/decode.rs 91.46% 18 Missing ⚠️
crates/polars-row/src/variable.rs 92.59% 2 Missing ⚠️
...ates/polars-arrow/src/array/fixed_size_list/mod.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19874      +/-   ##
==========================================
+ Coverage   79.43%   79.48%   +0.05%     
==========================================
  Files        1551     1554       +3     
  Lines      215222   216124     +902     
  Branches     2452     2452              
==========================================
+ Hits       170954   171787     +833     
- Misses      43710    43780      +70     
+ Partials      558      557       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ritchie46 ritchie46 merged commit 132c64d into pola-rs:main Nov 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support arbitrary nested lists in row-encoding
2 participants