-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Implement nested row encoding / decoding #19874
Merged
ritchie46
merged 15 commits into
pola-rs:main
from
coastalwhite:refactor/nested-row-encoding
Nov 22, 2024
Merged
refactor: Implement nested row encoding / decoding #19874
ritchie46
merged 15 commits into
pola-rs:main
from
coastalwhite:refactor/nested-row-encoding
Nov 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coastalwhite
changed the title
get started on nested row encoding
refactor: Implement nested row encoding / decoding
Nov 20, 2024
github-actions
bot
added
internal
An internal refactor or improvement
python
Related to Python Polars
rust
Related to Rust Polars
and removed
title needs formatting
labels
Nov 20, 2024
coastalwhite
force-pushed
the
refactor/nested-row-encoding
branch
from
November 20, 2024 12:01
5987a59
to
3e5c309
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19874 +/- ##
==========================================
+ Coverage 79.43% 79.48% +0.05%
==========================================
Files 1551 1554 +3
Lines 215222 216124 +902
Branches 2452 2452
==========================================
+ Hits 170954 171787 +833
- Misses 43710 43780 +70
+ Partials 558 557 -1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
November 21, 2024 08:53
9 tasks
This was referenced Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds row encoding and decoding for nested types.
It is now possible to properly roundtrip
pl.List
,pl.Array
andpl.Struct
including their outer and inner validities through the row encoding en decoding.Fixes #10747.