perf: Half the size of Booleans in row encoding #19927
Merged
+133
−70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
performance
9 tasks
coastalwhite
force-pushed
the
perf/bool-row-encoding
branch
from
4c3fd09
to
d1a172a
Compare
This changes the encoding of `pl.Boolean` in the row encoding from needing 2 bytes (1 for validity, 1 for value) to 1 byte. Now, the encoding of Boolean values is as follows: | Value | Encoding | |---------|----------| | `None` | `0x00` | | `False` | `0x20` | | `True` | `0x30` | The null is bitwise inverted for `nulls_last=True` and `False` / `True` are inverted for `descending=True`.
coastalwhite
force-pushed
the
perf/bool-row-encoding
branch
from
d1a172a
to
7615e2c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19927 +/- ##
=======================================
Coverage 59.28% 59.28%
=======================================
Files 1555 1555
Lines 216180 216213 +33
Branches 2456 2456
=======================================
+ Hits 128155 128177 +22
- Misses 87467 87478 +11
Partials 558 558 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
coastalwhite
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
ritchie46
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the encoding of
pl.Booleanin the row encoding from needing 2 bytes (1 for validity, 1 for value) to 1 byte. Now, the encoding of Boolean values is as follows:None0x00False0x20True0x30The null is bitwise inverted for
nulls_last=TrueandFalse/Trueare inverted fordescending=True.This is a continuation of #19874.