Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Revert "Use auto_doc_cfg" #6164

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

ritchie46
Copy link
Member

Reverts #6146

Doesn't seem to work. :(

@ritchie46 ritchie46 changed the title Revert "Use auto_doc_cfg" chore(rust): Revert "Use auto_doc_cfg" Jan 11, 2023
@ritchie46 ritchie46 merged commit 557f986 into master Jan 11, 2023
@ritchie46 ritchie46 deleted the revert-6146-issue_6123 branch January 11, 2023 08:05
@github-actions github-actions bot added chore Maintenance work that does not impact the user rust Related to Rust Polars labels Jan 11, 2023
@n8henrie
Copy link
Contributor

n8henrie commented Jan 11, 2023

Doesn't seem to work

@ritchie46 Uh oh -- can you elaborate a bit?

Was it not working locally? On GitHub Pages? On docs.rs?

Sorry for the trouble, I'll try to replicate and try again.

EDIT: And was it breaking? Or just failing to fix the issue I was hoping to fix? (I presume the former, otherwise it seem seemed to simplify the code a bit.)

@ritchie46
Copy link
Member Author

On github pages. There were no feature tags shown.

n8henrie added a commit to n8henrie/polars that referenced this pull request Jan 13, 2023
Reverts a revert

This reverts commit 557f986.
ritchie46 pushed a commit that referenced this pull request Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance work that does not impact the user rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants