Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "doc_auto_cfg" again (#6164) #6201

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Conversation

n8henrie
Copy link
Contributor

Reverts the revert.

(This reverts commit 557f986.)

Seems to be building and displaying correctly at my fork:
https://n8henrie.com/polars/polars/prelude/enum.Expr.html#method.diff

Fixes #6123

Let's not merge to master quite yet to see if I can figure out why it's
working for me but didn't last time you merged.

Reverts a revert

This reverts commit 557f986.
@ritchie46
Copy link
Member

Alright. I give it a second spin.

@ritchie46 ritchie46 merged commit 6ad5b03 into pola-rs:master Jan 17, 2023
@n8henrie
Copy link
Contributor Author

🤞

@n8henrie
Copy link
Contributor Author

n8henrie commented Jan 17, 2023

Seems to be working. All actions have completed, and clearing cache and reloading https://pola-rs.github.io/polars/polars/prelude/enum.Expr.html#method.diff I see

5DD955EC-30E6-4E77-A7FE-3D1BD0ED8DA6

@ritchie46
Copy link
Member

Yeap, I see it too! Thanks a lot @n8henrie 🙌

@n8henrie
Copy link
Contributor Author

Good deal. I'll keep my eye out for the next release to crates.io to make sure docs.rs is also working -- the original cause for the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rust Documentation: feature flag requirements not showing on docs.rs?
2 participants