perf(rust): update string replacement codepaths following new benchmarking #6777
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prepare for graphs :)
TLDR
str::replacen
, and use the regex engine for all other literal replacements (where len(s) > 32).NoExpand
) now outperforms in essentially all string regimes (from small to large), allowing us to both simplify the code and get a bit of extra performance in the small-string regime.Build
Compiled with:
Compared
Results
Tested on strings between 8 - 4096 chars in length, replacing between 0% and 100% of the target string, averaging a large number of repeat runs to reduce timing noise...
polars_str_replace_bench.xlsx