Speed up replacen loop #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xkr47
force-pushed
the
speed-up-replacen-loop
branch
from
07104e2 to
a8358e6
Compare
crapStone
added a commit
to Calciumdibromid/CaBr2
that referenced
this pull request
Jan 10, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [regex](https://github.com/rust-lang/regex) | dependencies | patch | `1.7.0` -> `1.7.1` | --- ### Release Notes <details> <summary>rust-lang/regex</summary> ### [`v1.7.1`](https://github.com/rust-lang/regex/blob/HEAD/CHANGELOG.md#​171-2023-01-09) [Compare Source](rust-lang/regex@1.7.0...1.7.1) \================== This release was done principally to try and fix the doc.rs rendering for the regex crate. Performance improvements: - [PERF #​930](rust-lang/regex#930): Optimize `replacen`. This also applies to `replace`, but not `replace_all`. Bug fixes: - [BUG #​945](rust-lang/regex#945): Maybe fix rustdoc rendering by just bumping a new release? </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC45NC4wIiwidXBkYXRlZEluVmVyIjoiMzQuOTQuMCJ9--> Co-authored-by: cabr2-bot <cabr2.help@gmail.com> Co-authored-by: crapStone <crapstone01@gmail.com> Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1711 Reviewed-by: crapStone <crapstone@noreply.codeberg.org> Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org> Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replacen()(and therefore alsoreplace()) was postponing checking against thelimituntil next iteration, which causes it to unnecessarily execute a "find" one extra time after the limit has been reached.Also added two unit tests for
replacen()since there were none.