refactor(python): Reduce number of polars.internals imports #7628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zundertj
changed the title
zundertj
commented
Mar 18, 2023
|
Some nice changes 👍 CI fails due some issue with arrow; I updated the lockfile, if you rebase CI should pass. Please see #7638 - the changes to the |
zundertj
changed the title
github-actions
bot
added
python
|
@zundertj Could you rebase this? I'd like to get the changes in |
In most cases, we just need the type annotation, in TYPE_CHECKING blocks you can just import. And in other cases, the import actually works. Only did this for modules that are outside the DataFrame/Series/Expr objects, such as testing and utils.
zundertj
force-pushed
the
reduce_internals_imports
branch
from
a7868d9 to
a0f0b3d
Compare
|
Done. @stinodego you have probably done quite a few of these changes in other MR's, feel free to power on and ignore this. I dont have that much time on my hands at the moment.. |
stinodego
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most cases, we just need the type annotation, in TYPE_CHECKING blocks you can just import. And in other cases, the import actually works. Only did this for modules that are outside the DataFrame/Series/Expr objects, such as testing and utils.