Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(python): More internals cleanup #7638

Merged
merged 7 commits into from
Mar 19, 2023
Merged

refactor(python): More internals cleanup #7638

merged 7 commits into from
Mar 19, 2023

Conversation

stinodego
Copy link
Contributor

@stinodego stinodego commented Mar 19, 2023 •
edited
Loading

Partially addresses #7506

Moving a lot of I/O functionality out of the internals module.

Changes:

  • Move internals.batched to io.csv.batched_reader
  • Move internals.io_excel to io.excel._write_utils
  • Move internals.anonymous_scan to io.parquet/ipc/pyarrow_dataset.anonymous_scan
  • Move functionality from internals.io to io module
  • Adjust modules for circular imports

@github-actions github-actions bot added python Related to Python Polars refactor Code improvements that do not change functionality labels Mar 19, 2023
@stinodego stinodego mentioned this pull request Mar 19, 2023
Merged
@stinodego stinodego force-pushed the more-internals-cleanup branch from bca39d3 to bc327c0 Compare March 19, 2023 17:46
@stinodego stinodego merged commit 5e0c229 into pola-rs:master Mar 19, 2023
@stinodego stinodego deleted the more-internals-cleanup branch May 25, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zundertj zundertj zundertj left review comments

Assignees
No one assigned
Labels
python Related to Python Polars refactor Code improvements that do not change functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stinodego @zundertj