-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(python): Rename venv
folder to .venv
#7790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great, thanks!
(Doh... for some reason I thought you already committed this 😅 - you'll need a quick rebase). |
That's fine, I've become quite adept at rebasing 😬 and this is about as simple as they come. |
One thing here - I wouldn't remove the original |
Yea in hindsight that was unnecessary - I'd approve a PR that re-adds it, however, probably best to delete the old folder and re-create the virtual env anyway, right? |
For sure - but it causes minor havoc until you do so; I just ran a Update: here it is - #7830 |
Triggered by #7782
I actually wanted to make this change a while ago. The naming of the venv folder does not matter much, but I think
.venv
is a bit nicer than simplyvenv
for a few reasons, explained well in PEP 704:Now that
maturin
will offer some automatic support when using.venv
, I think that's a valid reason for switching.