feat(python): allow Series init with Unknown dtype to proceed as if dtype is None, to allow inference
#7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… dtype is None (to allow inference)
github-actions
bot
added
enhancement
LdRoW
pushed a commit
to LdRoW/polars
that referenced
this pull request
Mar 28, 2023
… dtype is `None`, to allow inference (pola-rs#7830)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Unknowndtype isn't invalid, it's just... "unknown". So, this PR allows for inference if aSeriesis declared as havingUnknowndtype at init time; this is equivalent to dtype=None, and is also consistent with the the way that PyDataFrameread_rowsandread_dictsschema overrides behave.Also:
Added missing imports that were declared in
polars.datatypes.__init__.__all__, but that weren't actually being imported at that level.Reinstated
venvinto gitignore for the time-being; otherwise ~18,000 files show up as unversioned andtyposgoes bananas onpre-commit(spraying megabytes of text into your terminal) if you haven't both created the new/preferred.venvand deleted the oldvenv. Will smooth things over until everyone has transitioned.