Chore: update conversions and error-handling #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge remote-tracking branch 'origin/main' into more_rpolarserr # Conflicts: # src/rust/src/rlib.rs
Merge remote-tracking branch 'origin/main' into more_rpolarserr # Conflicts: # R/expr__expr.R # man/Expr_diff.Rd
Merge branch 'main' into more_rpolarserr # Conflicts: # NEWS.md # src/rust/src/lazy/dsl.rs
Merge branch 'main' into more_rpolarserr # Conflicts: # NEWS.md
sorhawell
changed the title
eitsupi
reviewed
Nov 29, 2023
eitsupi
requested changes
Dec 1, 2023
eitsupi
reviewed
Dec 1, 2023
There was a problem hiding this comment.
It looks like the wrong update was committed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor error handling of about 20 methods where return signature is
-> Listpr-> Result<_, String>.Update conversions to use solely robj_to!
From a text search it appears there are at least 100 more methods/functions due to refactoring.
I prefer to wrap up this PR and start a new one.