-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: Rename structs in Rust to rename classes in R #554
Conversation
This comment was marked as duplicate.
This comment was marked as duplicate.
This looks very good! I would see it as minor change as some user may have written using class() or inherits() and there have to adjust the class name. Funny thing @paleolimbot suggested this change very early in the project history, and I was like no that would be terrible. I finally came around to like it :) If you like you can also split it into a couple of PRs. |
I looked to as if the checks were passing. I they are not and this is a draft.
Yes I'll put this in the NEWS
I think I'll do all at once here |
Thanks for working at this! |
…into rename-classes
I'm wondering if I should add the What do you think? |
I think so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Awesome work!
aa5d9ec
to
1fd4785
Compare
I think we may have to merge #516 first. |
1fd4785
to
35eebec
Compare
Thanks for completing this PR @eitsupi |
Close #149
I just renamed the LazyFrame class (on R side) and struct (on rust side) to RPolarsLazyFrame. This compiles and works fine. We don't need to change the docs since this is only an internal (breaking) change.
@sorhawell @eitsupi if you agree with this then I can move forward and rename DataFrame and Expr