Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused weight files #57

Merged
merged 12 commits into from
Jan 10, 2024
Merged

Remove unused weight files #57

merged 12 commits into from
Jan 10, 2024

Conversation

ggwpez
Copy link
Member

@ggwpez ggwpez commented Oct 6, 2023

Deleting the weight files of all pallets that were undeployed by the OpenGov migration.
Kusama still had one duplicate file for the balances.
Also contains #58

ggwpez added 5 commits October 6, 2023 17:22
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez ggwpez marked this pull request as ready for review October 6, 2023 19:37
relay/kusama/src/lib.rs Outdated Show resolved Hide resolved
@bkontur bkontur mentioned this pull request Dec 19, 2023
9 tasks
ggwpez added 2 commits January 9, 2024 21:52
Signed-off-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io>
@ggwpez
Copy link
Member Author

ggwpez commented Jan 10, 2024

/merge

@fellowship-merge-bot
Copy link
Contributor

Enabled auto-merge in Pull Request

Available commands
  • /merge: Enables auto-merge for Pull Request
  • /merge cancel: Cancels auto-merge for Pull Request
  • /merge help: Shows this menu

For more information see the documentation

@fellowship-merge-bot fellowship-merge-bot bot enabled auto-merge (squash) January 10, 2024 12:33
@bkontur
Copy link
Contributor

bkontur commented Jan 10, 2024

@NachoPal I think there is one more unused weight file: https://github.com/polkadot-fellows/runtimes/blob/oty-weight-cleanup/system-parachains/gluttons/glutton-kusama/src/weights/frame_system.rs should we remove it or add to weights/mod.rs and use it?

@fellowship-merge-bot fellowship-merge-bot bot merged commit a205a9a into main Jan 10, 2024
13 checks passed
@bkontur bkontur mentioned this pull request Jan 10, 2024
19 tasks
@NachoPal
Copy link
Contributor

@NachoPal I think there is one more unused weight file: https://github.com/polkadot-fellows/runtimes/blob/oty-weight-cleanup/system-parachains/gluttons/glutton-kusama/src/weights/frame_system.rs should we remove it or add to weights/mod.rs and use it?

I think we can remove it

@ggwpez ggwpez deleted the oty-weight-cleanup branch January 11, 2024 11:40
@bkontur
Copy link
Contributor

bkontur commented Jan 22, 2024

@NachoPal I think there is one more unused weight file: https://github.com/polkadot-fellows/runtimes/blob/oty-weight-cleanup/system-parachains/gluttons/glutton-kusama/src/weights/frame_system.rs should we remove it or add to weights/mod.rs and use it?

I think we can remove it

@NachoPal or what about setting SystemWeightInfo = ()?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants