Remove unused weight files #99
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there is another PR #57 what about rebasing this on the top of that? |
🤦 Let's close this PR for now then - I can reopen later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It causes some confusion when I was working on weights for bridge pallets - e.g. there were two copies of
pallet_xcm_benchmarks_fungible.rsandpallet_xcm_benchmarks_generic.rsand I wasn't sure - which one is actually used (until looking atweights/mod.rs).Three's also a lot of unused weight files in
polkadot-runtime, but they're referenced byrelay/polkadot/src/governance/old.rs, which is also not compiled, so those files are unused too. But maybe there's some reason to keep this old governance code (and hence weights it is using), so I left those files. Could also remove on demand