Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edge headers #343

Merged
merged 19 commits into from
Dec 12, 2022
Merged

Edge headers #343

merged 19 commits into from
Dec 12, 2022

Conversation

antdjohns
Copy link
Contributor

Summary

In support of the launchpad we are adding header options to client requests.

RV1:

  • RequestOption class created
  • options param added to all api endpoints.
  • header added to request.get

@antdjohns
Copy link
Contributor Author

I will restore conf formatting in the morning.

@antdjohns antdjohns marked this pull request as ready for review December 8, 2022 17:29
@antdjohns antdjohns added the don't merge Not ready to be merged at this time label Dec 8, 2022
examples/launchpad/README.md Outdated Show resolved Hide resolved
examples/launchpad/README.md Outdated Show resolved Hide resolved
examples/launchpad/README.md Outdated Show resolved Hide resolved
examples/launchpad/README.md Outdated Show resolved Hide resolved
examples/launchpad/README.md Outdated Show resolved Hide resolved
polygon/rest/base.py Outdated Show resolved Hide resolved
polygon/rest/models/request.py Outdated Show resolved Hide resolved
polygon/rest/models/request.py Outdated Show resolved Hide resolved
polygon/rest/models/request.py Outdated Show resolved Hide resolved
polygon/rest/models/request.py Show resolved Hide resolved
examples/launchpad/launchpad.py Outdated Show resolved Hide resolved
examples/launchpad/launchpad.py Outdated Show resolved Hide resolved
@antdjohns antdjohns requested a review from jbonzo December 9, 2022 17:43
polygon/rest/base.py Outdated Show resolved Hide resolved
remove redundancy.
@jbonzo jbonzo removed the don't merge Not ready to be merged at this time label Dec 12, 2022
@antdjohns antdjohns enabled auto-merge (squash) December 12, 2022 17:31
@antdjohns antdjohns merged commit 3cee0bc into master Dec 12, 2022
@antdjohns antdjohns deleted the edge-headers branch December 12, 2022 17:32
antdjohns added a commit that referenced this pull request Dec 12, 2022
* removed formatting from docs and unwated comment dupe

* Add headers from options

* Added options parameter to rest api functions.

* handle headers from options

* edge-headers push

* Attempting to use with options

* created response options class

* handle headers from options

* merge headers

* parameter type cleanup and None value handling in request.

* attempting to revert conf.py changes

* added concat_method to baseclient and test for requestoptions

* refactored and introduced more optionals for stricter use

* added type hinting to builder method returns. removed optional from edge_headers method

* removed one example from ./example/launchpad and renamed function

* lint

* Update polygon/rest/base.py

remove redundancy.

* Update examples/launchpad/launchpad.py

Co-authored-by: jbonzo <8647805+jbonzo@users.noreply.github.com>
antdjohns added a commit that referenced this pull request Dec 13, 2022
* replaced params with get_params which is standard

* lint

* refactors

* Bump black from 22.10.0 to 22.12.0 (#346)

Bumps [black](https://github.com/psf/black) from 22.10.0 to 22.12.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@22.10.0...22.12.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump types-setuptools from 65.6.0.1 to 65.6.0.2 (#347)

* Edge headers (#343)

* removed formatting from docs and unwated comment dupe

* Add headers from options

* Added options parameter to rest api functions.

* handle headers from options

* edge-headers push

* Attempting to use with options

* created response options class

* handle headers from options

* merge headers

* parameter type cleanup and None value handling in request.

* attempting to revert conf.py changes

* added concat_method to baseclient and test for requestoptions

* refactored and introduced more optionals for stricter use

* added type hinting to builder method returns. removed optional from edge_headers method

* removed one example from ./example/launchpad and renamed function

* lint

* Update polygon/rest/base.py

remove redundancy.

* Update examples/launchpad/launchpad.py

Co-authored-by: jbonzo <8647805+jbonzo@users.noreply.github.com>

* param handling and refactor cleanup

* removed named param

* lint

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: jbonzo <8647805+jbonzo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants