Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param handling #348

Merged
merged 11 commits into from
Dec 13, 2022
Merged

Param handling #348

merged 11 commits into from
Dec 13, 2022

Conversation

antdjohns
Copy link
Contributor

Arguments were not being included in request paths.

antdjohns and others added 8 commits December 11, 2022 17:34
Bumps [black](https://github.com/psf/black) from 22.10.0 to 22.12.0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](psf/black@22.10.0...22.12.0)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* removed formatting from docs and unwated comment dupe

* Add headers from options

* Added options parameter to rest api functions.

* handle headers from options

* edge-headers push

* Attempting to use with options

* created response options class

* handle headers from options

* merge headers

* parameter type cleanup and None value handling in request.

* attempting to revert conf.py changes

* added concat_method to baseclient and test for requestoptions

* refactored and introduced more optionals for stricter use

* added type hinting to builder method returns. removed optional from edge_headers method

* removed one example from ./example/launchpad and renamed function

* lint

* Update polygon/rest/base.py

remove redundancy.

* Update examples/launchpad/launchpad.py

Co-authored-by: jbonzo <8647805+jbonzo@users.noreply.github.com>
@antdjohns antdjohns marked this pull request as ready for review December 12, 2022 18:20
@jbonzo jbonzo requested a review from chaig15 December 12, 2022 19:32
polygon/rest/reference.py Outdated Show resolved Hide resolved
@antdjohns antdjohns requested a review from jbonzo December 12, 2022 21:54
@antdjohns antdjohns merged commit 0bad448 into master Dec 13, 2022
@antdjohns antdjohns deleted the param-handling branch December 13, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants