Correctly find custom-built llc (#4537)

Use `HINTS` instead of `PATHS` in the CMake `find_path` command that tries to find our custom-built `llc`. `HINTS` is searched before the system `PATH`, so a system `llc` will now no longer be picked before ours. --------- Co-authored-by: Sean T Allen <sean@seantallen.com>
ponylang · Nov 8, 2024 · 108289b · 108289b
1 parent 23c2bc9
commit 108289b
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/.release-notes/4537.md b/.release-notes/4537.md
@@ -0,0 +1,3 @@
+## Correctly find custom-built `llc` during build process
+
+Previously our CMake build was failing to find our custom-built `llc` binary, but builds worked by accident if there was a system `llc`.  The build system now finds our custom `llc` correctly.
diff --git a/src/libponyrt/CMakeLists.txt b/src/libponyrt/CMakeLists.txt
@@ -56,7 +56,7 @@ set(_ll_except_obj "${CMAKE_BINARY_DIR}/except_try_catch.o")
 
 find_file(_llc_command
     NAMES llc.exe llc
-    PATHS "${CMAKE_BINARY_DIR}/../../libs/bin" "${CMAKE_BINARY_DIR}/../libs/bin"
+    HINTS "${CMAKE_BINARY_DIR}/../../libs/bin" "${CMAKE_BINARY_DIR}/../libs/bin"
 )
 
 if(${CMAKE_HOST_SYSTEM_NAME} MATCHES "Darwin")
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,3 @@
		## Correctly find custom-built `llc` during build process

		Previously our CMake build was failing to find our custom-built `llc` binary, but builds worked by accident if there was a system `llc`. The build system now finds our custom `llc` correctly.