Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly find custom-built llc #4537

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Correctly find custom-built llc #4537

merged 4 commits into from
Nov 8, 2024

Conversation

chalcolith
Copy link
Member

@chalcolith chalcolith commented Nov 8, 2024

Use HINTS instead of PATHS in the CMake find_path command that tries to find our custom-build llc. From the documentation for find_file it seems that PATHS is searched after the system PATH, so if there was a system llc that would get picked up first. Since HINTS is searched before PATH, our llc now gets picked up correctly.

Use `HINTS` instead of `PATHS` in the CMake `find_path` command that tries to find our custom-build `llc`. Not sure what the difference is, but this works on Ubuntu.
@chalcolith chalcolith added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label Nov 8, 2024
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Nov 8, 2024
@ponylang-main
Copy link
Contributor

Hi @chalcolith,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 4537.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

.release-notes/4537.md Outdated Show resolved Hide resolved
@chalcolith chalcolith merged commit 108289b into main Nov 8, 2024
24 checks passed
@chalcolith chalcolith deleted the issue_4536_llc_path branch November 8, 2024 19:30
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Nov 8, 2024
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
github-actions bot pushed a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants