fix: Override dh_installdeb to overwrite auto-generated conffiles #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pop-os/upgrade#319.
The standard
dh_installdeb
takes ourpop-default-settings.conffiles
list and adds its auto-detected conffiles (anything under/etc
) to that list. We need to override that by copying our list back over the generated one in order to prevent important files like/etc/os-release
and/etc/lsb-release
(which we package as/etc/pop-os/os-release
and/etc/pop-os/lsb-release
) from being declared as conffiles (which means they don't get updated by automated utilities like pop-upgrade).For QA, note that if you're testing this on a system affected by the bug (running Jammy but showing a different release name in
/etc/os-release
), you'll need to correct the suite for the staging repository after adding it, becauseapt-manage
will add it based on what's in/etc/os-release
//etc/lsb-release
.