Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C8 capture support #1286

Merged
merged 41 commits into from
Jul 22, 2023
Merged

C8 capture support #1286

merged 41 commits into from
Jul 22, 2023

Conversation

NotherNgineer
Copy link
Contributor

@NotherNgineer NotherNgineer commented Jul 20, 2023

Support for optionally saving Capture files in C8 format (converting from C16 to C8 as data is written to the file), and for reading C8 or C32 files during Replay/Playlist (automatically converting from C8/C32 to C16 as data is read from the file).

(A small part of enhancement request #1277)

@NotherNgineer
Copy link
Contributor Author

A test version of the firmware with these changes is on Discord here:
https://discord.com/channels/719669764804444213/722101917135798312/1131674484030570607

@NotherNgineer NotherNgineer marked this pull request as ready for review July 20, 2023 19:51
@Brumi-2021
Copy link
Contributor

Hi thanks 😊 for adding this nice feature !
I really wanted to have towards exploring to increase in future a good quality capture / replay at 1 MHz , 2Mhz .

I just evaluated quickly in capture / replay at 250/500 Khz some broadband FM in .c8/.c16 , and seems to work correctly .( at < = 500 Khz seems all ok )

I also tried to reproduce some large .c8 file 240 MB recorded with 2Mhz rate and found two issues :

1-) the second % bar reproduction status is only using low area 2 or 3 % and resets to zero and again same .
(That bug was there before your change . Gps simul App works well using all % progress reproduction bar)

2-) comparing the reproduction quality , GPS simul reproduces with less digital errrors , better quality . I guess that is due to that GPS simul has not activated waterfall , and therefore not M4 skipping . But it is a very good first step !

but really great 👍 job !!!

@NotherNgineer NotherNgineer marked this pull request as draft July 21, 2023 03:38
@NotherNgineer
Copy link
Contributor Author

I changed this one back to a Draft so it won't get merged yet. (Don't hold up any potential 1.7.4 release for this one.)

@NotherNgineer NotherNgineer marked this pull request as ready for review July 22, 2023 06:51
@NotherNgineer NotherNgineer merged commit d6b0173 into portapack-mayhem:next Jul 22, 2023
3 checks passed
@NotherNgineer NotherNgineer deleted the c8 branch July 22, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants