Interim Capture hang workaround #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brumi-2021
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Yes thanks
I tested that exact work around in H1R2 and H2R4 and it solves all this strange initial hang up when going directly from boot to Capture App . It is a temporal c/m
(that line was already there in old fw , before introducing RxRadiostate , so no risk of side effects )
NotherNgineer
added a commit
to NotherNgineer/portapack-mayhem
that referenced
this pull request
Jul 20, 2023
|
Checked in today's merged next, and it works well , no problem. |
NotherNgineer
added a commit
that referenced
this pull request
Jul 22, 2023
* C8 conversion * C8 conversion * C8 support * C8 support * C8 support * C8 support * Don't auto-convert GPS C8 files * C8 support * C8 support * C8 support * Remove hang workaround (different PR) * Comment change * Clang * Clang * Clang * Merged change from PR #1287 * C8 support * C8 support * Improve bandwidth display * Merged minor optimization from PR 1289 * Merge change from PR 1289 * Use complex types for C8/C16 conversion * C8 support * C8 support * C8 support * C8 support * Roll back changes * Roll back C8 changes * C8 support * C8 support * C8 support * C8 support * C8 support * Don't transmit samples past EOF * Don't transmit samples past EOF * Clang * Clang attempt * Clang attempt * C8 support * Clang
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one-line kludge seems to work around a Capture hang issue on some PortaPack units when the Capture app is the first one executed after power-up, or after running Replay app with a high sample rate. It is not understood why this helps, as noted in the comment. Issue #1283.
This is a simple interim kludge meant to address the same issue as draft PR #1285.