-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
db restructuring and updates for SIWE based access and other future features! #146
Conversation
sync back to main
get updates from main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable, just a couple questions. Also, we should avoid doing this sort of migration reset going forward. Bad habits and all that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! My bad! Was setting up for next feature before I realised I should merge to main before going deep!
): boolean | Promise<boolean> | Observable<boolean> { | ||
console.log('Inside AuthGuard'); | ||
const request = context.switchToHttp().getRequest(); | ||
return true; // @note: temp returning true for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this for local testing or did you mean for this to make it to develop
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't mean to but didn't revert; working off this!
have reset migrations; db needs to be tear down and tear up