Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db restructuring and updates for SIWE based access and other future features! #146

Merged
merged 9 commits into from
Mar 2, 2024

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented Mar 2, 2024

have reset migrations; db needs to be tear down and tear up

@wtfsayo wtfsayo requested a review from plor March 2, 2024 16:58
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, just a couple questions. Also, we should avoid doing this sort of migration reset going forward. Bad habits and all that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! My bad! Was setting up for next feature before I realised I should merge to main before going deep!

): boolean | Promise<boolean> | Observable<boolean> {
console.log('Inside AuthGuard');
const request = context.switchToHttp().getRequest();
return true; // @note: temp returning true for testing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for local testing or did you mean for this to make it to develop?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't mean to but didn't revert; working off this!

@wtfsayo wtfsayo merged commit c8b0e17 into develop Mar 2, 2024
@wtfsayo wtfsayo deleted the db-updates branch March 2, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants