Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Auth with SIWE + Permissioned Area i.e. Dashboard #149

Merged
merged 16 commits into from
Mar 15, 2024

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented Mar 14, 2024

Backlog

  • logout from dashboard
  • create app rules (+ api key which is now a rule)
  • App Name feature

@wtfsayo wtfsayo requested a review from plor March 14, 2024 13:51
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I don't know bun to know whether the lock should be checked in. If that's fine go ahead and merge.

@@ -3,7 +3,7 @@ CREATE TYPE "TransactionType" AS ENUM ('CREDIT', 'DEBIT');

-- CreateTable
CREATE TABLE "Org" (
"id" VARCHAR(8) NOT NULL,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will require a reset of the db right? Fine here, but we should really start getting into better habits re: migration.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This probably shouldn't be checked in. Correct me if I'm wrong.

@wtfsayo wtfsayo merged commit a56b2f4 into develop Mar 15, 2024
@wtfsayo wtfsayo deleted the siwe-user-and-guards branch March 15, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants