Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

single stage build for docs #186

Merged
merged 2 commits into from
Apr 8, 2024
Merged

single stage build for docs #186

merged 2 commits into from
Apr 8, 2024

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented Apr 8, 2024

had quite a trouble with multi-stage build for docs (nextjs 13)

  • we can probably go with single stage build as not much size issue here of any kind

@wtfsayo
single stage build for docs
1d25b4a 
had quite a trouble with multi-stage build for docs (nextjs 13)

- we can probably go with single stage build as not much `size` issue here of any kind
@wtfsayo wtfsayo requested a review from plor April 8, 2024 11:53
plor
plor suggested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts now, so if you could rebase that would be great. I think we made the same change (node server.js -> npx next start)

@wtfsayo wtfsayo merged commit 7a7c3ef into develop Apr 8, 2024
@wtfsayo wtfsayo deleted the fix-docs-docker-build branch April 8, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plor plor plor requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtfsayo @plor