updates fly configs #189
Merged
updates fly configs #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plor
reviewed
Apr 10, 2024
| ARG NEXT_PUBLIC_RPC_ENDPOINT | ||
| ARG NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID | ||
| ARG NEXT_PUBLIC_APP_URL | ||
| ARG API_ENDPOINT |
There was a problem hiding this comment.
I still think we should figure out how to avoid this, but its ok for now. We should document it clearly though, since it isn't obvious why this is done this way.
There was a problem hiding this comment.
This is understandable needs a comment/flag
web-portal/frontend/fly.staging.toml
Outdated
Comment on lines
21
to
22
| NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID = 'wallet-connect-project-id' | ||
| NEXT_PUBLIC_RPC_ENDPOINT = 'rpc-endpoint' |
There was a problem hiding this comment.
This is actually setting the environment variables to this, they get overwritten by secrets, but it isn't clear that this is a great way to document the need for the secrets. Not sure though.
There was a problem hiding this comment.
I agree but we shouldn't put our secrets in repo anyway
There was a problem hiding this comment.
Right, but this doesn't do anything right here, so a bit confusing.
web-portal/frontend/fly.toml
Outdated
Comment on lines
23
to
24
| NEXT_PUBLIC_WALLETCONNECT_PROJECT_ID = 'wallet-connect-project-id' | ||
| NEXT_PUBLIC_RPC_ENDPOINT = 'rpc-endpoint' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
node_modules