Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update app #208

Merged
merged 4 commits into from
Apr 30, 2024
Merged

Update app #208

merged 4 commits into from
Apr 30, 2024

Conversation

wtfsayo
Copy link
Contributor

@wtfsayo wtfsayo commented Apr 29, 2024

tackles update/delete app #40

  • side updates; delete sets deletedAt in db
  • relevant apis filter out entities with deletedAt!=null

@wtfsayo wtfsayo requested a review from plor April 29, 2024 12:30
@benedictvscriticus benedictvscriticus mentioned this pull request Apr 29, 2024
Closed
plor
plor approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@plor plor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wtfsayo wtfsayo merged commit b25995c into develop Apr 30, 2024
@wtfsayo wtfsayo deleted the update-app branch May 4, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plor plor plor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wtfsayo @plor